Idea

Dan avatar image
Dan suggested nicholasschulist edited

Remove Platform.isFlex() from the SDK

Hi folks,

We have just had to figure out the hard way that this function doesn't work on Flex 2 devices. Perhaps instead of this teeny document suggesting we stop using this deprecated function, the function itself should be removed from the SDK so it isn't an issue for other developers?


Thanks!

Clover Android SDKClover Flex
10 |2000
Toggle Comment visibility. Current Visibility: Viewable by all users

Up to 2 attachments (including images) can be used with a maximum of 512.0 KiB each and 1.0 MiB total.

2 Comments

·
Jeffrey Blattman avatar image
Jeffrey Blattman commented

The entire Platform class was deprecated 2 years ago, as well as the isCloverFlex() method. The deprecation warning in the javadocs state:

/**
 * <b>Please discontinue using this class, it has been deprecated and will be deleted in a
 * future version of the Clover Android SDK!</b>
 * <p>
 * Code which references this class almost certainly will not work on future Clover devices or even
 * slight model variations.
 * </p><p>
 * Clover frequently adds new models for existing devices when shipping devices to new
 * regions. Please use {@link com.clover.sdk.util.Platform2} and/or relevant Android APIs to write
 * code compatible with future devices that may have different screen sizes or hardware features.
 * </p>
 */

We do plan to remove it from the SDK. The process is that we first deprecate to give developers time to migrate. You're right it's probably about time to take some action.

1 comment
10 |2000
Toggle Comment visibility. Current Visibility: Viewable by all users

Up to 2 attachments (including images) can be used with a maximum of 512.0 KiB each and 1.0 MiB total.

Dan avatar image Dan commented ·

Thanks for this Jeff, I am good at ignoring deprecation warnings due to supporting SDK 17 :)

0 Likes 0 ·
nicholasschulist avatar image
nicholasschulist commented nicholasschulist edited

Either deprecated features should be taken away or come with clear warnings, especially if they cause problems on certain devices like the Flex 2 raft wars. You can help keep other developers from having the same problem by telling the people who update the SDK about this.

10 |2000
Toggle Comment visibility. Current Visibility: Viewable by all users

Up to 2 attachments (including images) can be used with a maximum of 512.0 KiB each and 1.0 MiB total.

Write a Comment

Up to 8 attachments (including images) can be used with a maximum of 1.0 MiB each and 10.0 MiB total.

Welcome to the
Clover Developer Community

Your Opinion Counts

Share your great idea, or help out by voting for other people's ideas.

Related Ideas

End of Day Report - Ability to Select Multiple Devices in One Report